refactor(logging): encapsulate conditional logic into methods for bet… #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter readability and maintainability - Encapsulated directory creation and permission checks in `AbstractFileHandler` into dedicated methods. - Refactored threshold checking logic in `LoggerManager` for improved clarity. - Encapsulated rate-limiting logic in `RateLimiter` to separate concerns. - Improved file rotation checks in `RotatingFileHandler` by creating a method to determine when to rotate. - Isolated Slack request logic in `SlackClient` to streamline error handling and HTTP requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ter readability and maintainability
AbstractFileHandlerinto dedicated methods.LoggerManagerfor improved clarity.RateLimiterto separate concerns.RotatingFileHandlerby creating a method to determine when to rotate.SlackClientto streamline error handling and HTTP requests.